Captain's Log: Stardate 78009.3

Nothing too exciting today -- I mostly continued working on improving the voice instancing and MPE support.

The biggest bug I fixed had to do with noises that would appear when the user moved the slider that adjusts how many voice instances are available. When the slider was increased, you'd get clanking noises from the model, and it was obvious that somehow the new instances were not being initialized properly. This turned out to be really simple; basically there was a little bit of state about whether an entity had been initialized that was not being stored per-instance but only per-entity. So this was a simple fix and now the noises no longer occur.

I also implemented support for MIDI note OFF velocity as a modulation source. I had simply overlooked this before when I added note ON velocity. Now the MidiVelocity modulator sub-type offers "Velocity Phase" as an option where you can choose Note On Velocity or Note Off Velocity, and I added a golden test for this.